Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'good second issue' from CONTRIBUTING.md Section 2.3.b #5699

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

segbuniwe
Copy link
Member

Fixes #5591

What changes did you make?

  • Removed section about "Complexity: Good second issue" from section 2.3.b of CONTRIBUTING.md

Why did you make the changes (we will use this info to test)?

  • To avoid confusion since issues with "Complexity: Good second issue" will no longer be made

For Reviewers: Do not review locally, rather review changes at https://github.com/segbuniwe/website/blob/remove-second-issue-5591/CONTRIBUTING.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-10-10 at 5 09 05 PM
Visuals after changes are applied Screenshot 2023-10-10 at 5 19 54 PM

@blulady blulady requested review from mademarc and k-rewd October 11, 2023 02:16
@mademarc
Copy link
Member

Review ETA: 10/12/2023
Availability: 7:13PM

mademarc
mademarc previously approved these changes Oct 13, 2023
Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @segbuniwe well done on the removal of this "good second issue" so the developer can get ger the task done.

Copy link
Member

@k-rewd k-rewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I see that the changes you made are correct! However, I do find it odd that 50 lines of code have been changed with your commit, although it seems like its just the spaces at the end that have been removed. I might have missed something but I did message @blulady just in case. In the meantime, please add the labels attached issue 5591 to the PR.
image
Other than that, I think it's good to go! Appreciate your time and effort and thank you for contributing!

@segbuniwe segbuniwe added Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less labels Oct 14, 2023
@segbuniwe segbuniwe requested a review from k-rewd October 14, 2023 04:01
k-rewd
k-rewd previously approved these changes Oct 14, 2023
Copy link
Member

@k-rewd k-rewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Labels have been added nicely. Thank you!

@t-will-gillis t-will-gillis self-requested a review October 15, 2023 16:16
t-will-gillis
t-will-gillis previously approved these changes Oct 15, 2023
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @segbuniwe - Great job! Branches are correct, you are linked to the original issue, you are briefly explaining what you changed and why, and you are providing relevant before and after screenshots. Your code edits are clean- as @k-rewd noted, it appears your ide deleted whitespace in several areas which is fine here. Otherwise, thanks for working with @k-rewd to add labels (for future reference: it may be that you created the PR before specifying the "Fixes: #" so the bot did not fill in the labels automatically).

Thanks for your work!

@t-will-gillis t-will-gillis dismissed stale reviews from k-rewd, mademarc, and themself via ccbb82b October 15, 2023 16:29
@t-will-gillis t-will-gillis self-requested a review October 15, 2023 16:29
@t-will-gillis t-will-gillis merged commit c15b550 into hackforla:gh-pages Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "good second issue" from CONTRIBUTING.md Section 2.3.b
4 participants