-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed 'good second issue' from CONTRIBUTING.md Section 2.3.b #5699
Removed 'good second issue' from CONTRIBUTING.md Section 2.3.b #5699
Conversation
Review ETA: 10/12/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @segbuniwe well done on the removal of this "good second issue" so the developer can get ger the task done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I see that the changes you made are correct! However, I do find it odd that 50 lines of code have been changed with your commit, although it seems like its just the spaces at the end that have been removed. I might have missed something but I did message @blulady just in case. In the meantime, please add the labels attached issue 5591 to the PR.
Other than that, I think it's good to go! Appreciate your time and effort and thank you for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Labels have been added nicely. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @segbuniwe - Great job! Branches are correct, you are linked to the original issue, you are briefly explaining what you changed and why, and you are providing relevant before and after screenshots. Your code edits are clean- as @k-rewd noted, it appears your ide deleted whitespace in several areas which is fine here. Otherwise, thanks for working with @k-rewd to add labels (for future reference: it may be that you created the PR before specifying the "Fixes: #" so the bot did not fill in the labels automatically).
Thanks for your work!
ccbb82b
Fixes #5591
What changes did you make?
Why did you make the changes (we will use this info to test)?
For Reviewers: Do not review locally, rather review changes at https://github.com/segbuniwe/website/blob/remove-second-issue-5591/CONTRIBUTING.md
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied