Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wins.js so the Wins page uses icon-github.svg #7691

Closed
wants to merge 1 commit into from
Closed

Update wins.js so the Wins page uses icon-github.svg #7691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/js/wins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
const cardTemplate = document.getElementById("wins-card-template");
const QUOTE_ICON_PATH = '/assets/images/wins-page/quote-icon.svg'
const AVATAR_DEFAULT_PATH = "/assets/images/wins-page/avatar-default.svg"
const GITHUB_ICON = '/assets/images/wins-page/icon-github-small.svg';
const GITHUB_ICON = `{% include svg/icon-github.svg %}`;
const LINKEDIN_ICON = '/assets/images/wins-page/icon-linkedin-small.svg'
const winsCardContainer = document.querySelector('#responses');

Expand Down Expand Up @@ -506,7 +506,7 @@ function changeSeeMoreBtn(x) {
if (data[i][linkedin_url].length > 0) {
makeIcon(data[i][linkedin_url], overlayIcons, 'linkedin-icon', '/assets/images/wins-page/icon-linkedin-small.svg', 'LinkedIn profile for ' + data[i][name]);
} if (data[i][github_url].length > 0) {
makeIcon(data[i][github_url], overlayIcons, 'github-icon', '/assets/images/wins-page/icon-github-small.svg', 'Github profile for ' + data[i][name]);
makeIcon(data[i][github_url], overlayIcons, 'github-icon', `{% include svg/icon-github.svg %}`, 'Github profile for ' + data[i][name]);
}

const overlayName = document.querySelector('#overlay-name');
Expand Down
Loading