Removed api-actionnetwork Script from default-markdown.html and JS file from assets/js #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: back end/devOps
|
Review ETA: 11/15/2024 Friday |
siyunfeng
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Great job working on this issue, @floydferrer !
- The branch you made changes on is correct
- The branch name is clear and detailed
- Availability and ETA are provided in the original issue
- The linked issue is included
- The changes you made are accurate
- The CodeQL Alerts are checked
Everything looks awesome. Thank you for your contribution!
FamousHero
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Hi @floydferrer, Thanks for taking on this issue!
Things you did well:
- branch name contains issue #
- PR title and description sections are descriptive and succinct.
Tested on my local machine and everything looks good. No changes needed, great job! Keep it up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7091
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)