Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Member Anousha Shadrach From LA TDM Calculator #7768

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Remove Member Anousha Shadrach From LA TDM Calculator #7768

merged 2 commits into from
Nov 27, 2024

Conversation

dvernon5
Copy link
Member

@dvernon5 dvernon5 commented Nov 26, 2024 •
edited
Loading

Fixes #7651

What changes did you make?

  • Removed the name Anousha Shadrach from the _projects/tdm-calculator.md path.

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before_Webpage_Changes

Visuals after changes are applied

After_Webpage_Changes

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dvernon5-remove-member-anousha-7651 gh-pages
git pull https://github.com/dvernon5/website.git remove-member-anousha-7651

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 26, 2024
@mchait18 mchait18 self-requested a review November 26, 2024 15:01
@mchait18
Copy link
Member

Review ETA: 1 PM 11/26/2024
Availability: 9-3 PM EST Mon-Thurs

mchait18
mchait18 requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@mchait18 mchait18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue, @dvernon5 !

You're doing these right:

  • The branch you made the change on is correct
  • The linked issue (original issue) number is included
  • The content required to remove is accurate
  • The before / after screenshot is helpful to display the change

Changes you need to make:

  • Address the questions from HackforLABot in the original issue ( comment your Availability and ETA)

  • The items on the original issue should be checked off when items are addressed

  • You can re-request me to review your PR once you make the changes. Feel free to reach out if you have any questions.

@mchait18 mchait18 mentioned this pull request Nov 26, 2024
Open
@codyyjxn codyyjxn self-requested a review November 26, 2024 17:02
codyyjxn
codyyjxn approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvernon5 great job on taking this gfi.

Things that went well

  • The branch name is correct
  • The issue is linked
  • The before and after photos are great

Some suggestions

  • You need to respond to the HackForLA bot in the issue
  • You need to check the boxes from the original issue as well
  • You can also remove the issue number from the title

Keep it up !

@dvernon5 dvernon5 changed the title Remove member anousha 7651 Remove Member Anousha Shadrach From LA TDM Calculator Nov 26, 2024
@dvernon5
Copy link
Member Author

@mchait18 @codyyjxn

Thank you for your feedback. I wanted to inform y'all that I made the following changes that y'all suggested. Thank you for your time.

minkang3
minkang3 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@minkang3 minkang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are perfect, you did exactly what the issue specified.
Branch name looks good.
For the "Why did you make the changes?" section, don't just say that the issue specified it, say why did the issue specify it.

Overall looks good to me.

@dvernon5
Copy link
Member Author

@minkang3

Thank you for your feedback. I took your advice and re-edit my answer to the given question "Why did you make the changes?". I hope that is a better response.

Thank you once again.

@rachelcorawood rachelcorawood self-requested a review November 26, 2024 20:26
@rachelcorawood
Copy link
Member

Review ETA: 2 PM 11/26/2024
Availability: 9am-3 PM PST Mon-Wed and Friday This week

rachelcorawood
rachelcorawood approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rachelcorawood rachelcorawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvernon5 great job successfully removing Anousha Shadrach from the LA TCM Calculator.

Things that went well
-The branch name is correct
-The issue is linked
-The before and after photos are great
-You responded to the bot
-You removed the issue number from the title

@dvernon5
Copy link
Member Author

@rachelcorawood
Thank you for your time and feedback. I am glad everything looks good.

@codyjohnsontx codyjohnsontx self-requested a review November 26, 2024 21:57
@codyjohnsontx
Copy link
Member

Review ETA: 4:30pm 11/26/2024
Availability: 10-6 PM CST Mon-Fri

codyjohnsontx
codyjohnsontx approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@codyjohnsontx codyjohnsontx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch name looks good
The code changes look perfect.
The issue is linked correctly
CodeQL alerts are good
The content removed is corrrect
Before and After photos look great

Good job on the PR @dvernon5 and thank you for your time

@codyjohnsontx codyjohnsontx mentioned this pull request Nov 26, 2024
Open
@dvernon5
Copy link
Member Author

@codyjohnsontx

Thank you for your feedback and time. I truly appreciate it, and I am glad everything is looking good.

@daras-cu daras-cu merged commit 8f876e0 into hackforla:gh-pages Nov 27, 2024
13 checks passed
@rachelcorawood rachelcorawood mentioned this pull request Nov 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyyjxn codyyjxn codyyjxn approved these changes

@mchait18 mchait18 mchait18 approved these changes

@rachelcorawood rachelcorawood rachelcorawood approved these changes

@minkang3 minkang3 minkang3 approved these changes

@codyjohnsontx codyjohnsontx codyjohnsontx approved these changes

@kotynskm kotynskm Awaiting requested review from kotynskm

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Remove Anousha Shadrach
7 participants
@dvernon5 @mchait18 @rachelcorawood @codyjohnsontx @minkang3 @codyyjxn @daras-cu