Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Member Nooria Ali To Civic Tech Jobs #7773

Merged

Conversation

dvernon5
Copy link
Member

@dvernon5 dvernon5 commented Nov 27, 2024

Fixes #7730

What changes did you make?

  • Added the name Nooria Ali to _project/civic-tech-jobs.md

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Before_Webpage_Changes

Visuals after changes are applied

After_Webpage_Changes

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dvernon5-add-member-nooria-ali-7730 gh-pages
git pull https://github.com/dvernon5/website.git add-member-nooria-ali-7730

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 27, 2024
@dvernon5 dvernon5 requested a review from sakibian November 27, 2024 04:55
@mchait18 mchait18 self-requested a review November 27, 2024 14:26
@mchait18
Copy link
Member

Review ETA: 12 PM 11/27/24
Availability: 10-3 PM EST M-F

@mugdhchauhan
Copy link
Member

Review ETA: 27 Nov @ 6 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

@mugdhchauhan mugdhchauhan self-requested a review November 27, 2024 14:42
Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

@dvernon5 Thank you for your PR.

Things that went well

  • Providing Availability & ETA in the issue.
  • Good PR title, issue number is added, what changes you made and why are clear, good screenshots, and CodeQL alerts have been checked.
  • Branch name is ok but can be better.
  • I can see the changes in my local environment.
  • All links are working fine e.g. GitHub and Slack.

Things to change

I have approved this PR because the code is fine but please make the following changes:

  • In the comments on the changes in the Pull Request for your particular file path use backticks (`) to enclose the file path such as _projects/expunge-assist.md.
  • For the PR title: it is 'Civic Tech Jobs' not 'Civic Tech Job'. Please rename PR title.

Suggestion (for your next task): the branch name could be better by using a more descriptive branch name such as Civic-Tech-Jobs-add-Nooria-Ali-7730.

Thank you. I appreciate your work. Feel free to ask if you have any questions.

Copy link
Member

@mchait18 mchait18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dvernon5

  • The code changes look good.
  • The issue is linked correctly
  • CodeQL alerts are checked
  • The original issue items are checked
  • The content added is correct
  • Before and After photos are accurate

Great job

@dvernon5 dvernon5 changed the title Added Member Nooria Ali To Civic Tech Job Added Member Nooria Ali To Civic Tech Jobs Nov 27, 2024
@dvernon5
Copy link
Member Author

@mugdhchauhan

Thank you for your feedback. I took your advice and made the following changes. Also, I will be more descriptive of my branch name for the next issue.

Once again thank you for all of your suggestions.

@dvernon5
Copy link
Member Author

@mchait18

Thank you for your time and feedback. I truly appreciate it.

@codyyjxn codyyjxn self-requested a review November 27, 2024 17:16
@belunatic
Copy link
Member

Review ETA: 12 PM 11/27/24
Availability: 2-4 PM PST M,W,F

@belunatic belunatic self-requested a review November 27, 2024 18:14
Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvernon5

Amazing job!

  • Issue number present
  • Images are perfect
  • Code added is clear and concise

Thank you for taking care of the issues stated by @mugdhchauhan

Great Job and Happy Thanksgiving!

@rachelcorawood
Copy link
Member

Review ETA: noon 11/27/24
Availability: Available W & F Before 3pm

Copy link
Member

@rachelcorawood rachelcorawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

-You completed it in the right branch
-You linked the issue
-You understand the issue and executed well
-Included visuals
-Made the recently requested updates from other reviews!

Thank you!

@t-will-gillis t-will-gillis merged commit fcaeea0 into hackforla:gh-pages Nov 27, 2024
13 checks passed
@dvernon5 dvernon5 deleted the add-member-nooria-ali-7730 branch November 27, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Nooria Ali
6 participants