-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced label in img-tag-refactor-on-website.md #7791
Replaced label in img-tag-refactor-on-website.md #7791
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sujay-Anantha thank you for taking on this issue.
Things that went well
- The title is correct
- The branch name is correct
- The changes are made correct as well
Keep it up!
Review ETA: 12/6/2024 Friday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job working on this issue, @Sujay-Anantha !
You did well on these:
- The original issue is linked
- Availability and ETA are provided in the original issue
- The change you made in the corresponding file is accurate
- The CodeQL Alerts are checked
- The URL of the updated issue template is correct
- The change is applied to the updated issue template
- The corresponding labels match the updated issue template
Things to improve:
- Provide the corresponding answer to the
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
section. If there are visual changes to the website, include the before-and-after screenshots. Otherwise, keep the- No visual changes to the website
from theNotes
.
Reminder:
- After PR is merged, follow the instructions in the original issue to change your default branch back to
gh-pages
and disable theIssues
feature
Thank you for your contribution!
Fixes #7604
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
For Reviewers
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)