-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update skills issue template label #7945
base: gh-pages
Are you sure you want to change the base?
update skills issue template label #7945
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerioduenas Great job on your Medium Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
.github/ISSUE_TEMPLATE/skills-issue--developer.md
was edited - No extra edits were made
- Appearance of the website is unchanged (Chrome and Firefox)
Approved! 👍
Availability: Thur 9a - 2p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rogerioduenas a great job
- The branch name is on point
- I love you mentioned the file you made the changes but it would be great if you added the " ` " to make it look like this
in skills-issue--developer.md
. - code changes are on point
great job!
Fixes #7605
What changes did you make?
skills-issue--developer.md
.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
For Reviewers
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)