Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced prompt for adding ready for dev lead label with prompt for adding ready for merge team label #7948

Open
wants to merge 12 commits into
base: gh-pages
Choose a base branch
from

Conversation

iancooperman
Copy link
Member

@iancooperman iancooperman commented Feb 26, 2025

Fixes #7606

What changes did you make?

  • Edited line 353 to reference the ready for merge team label instead of the ready for dev lead label.

Why did you make the changes (we will use this info to test)?

  • The process is being modified so that the merge team can handle more issue reviews.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

For Reviewers

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 1pt Can be done in 4-6 hours labels Feb 26, 2025
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b iancooperman-replace-label-in-profile-card-review-7606 gh-pages
git pull https://github.com/iancooperman/hackforla-website.git replace-label-in-profile-card-review-7606

@iancooperman
Copy link
Member Author

What the heck? Why are there so many commits in this? This only touches one line of one file...

Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iancooperman

What went well:

  • Although the task had a lot of step, you took care of each one of them great job
  • Code was updated to match the changes
  • branch name is relevance and matches the objective

Things to consider:

  • in the "What changes you made" add the filepath and the line you changed
  • Checking of the CodeQL Alert

Great work @iancooperman and thank you

@Cloid
Copy link
Member

Cloid commented Feb 28, 2025

Review ETA: EOD 3/07/25
Availability: 5-8 PM Weekdays

@Cloid Cloid self-requested a review February 28, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

Replace label in project-profile-card-review-and-update.yml
3 participants