-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced prompt for adding ready for dev lead
label with prompt for adding ready for merge team
label
#7948
base: gh-pages
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
What the heck? Why are there so many commits in this? This only touches one line of one file... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What went well:
- Although the task had a lot of step, you took care of each one of them great job
- Code was updated to match the changes
- branch name is relevance and matches the objective
Things to consider:
- in the "What changes you made" add the filepath and the line you changed
- Checking of the CodeQL Alert
Great work @iancooperman and thank you
Review ETA: EOD 3/07/25 |
Fixes #7606
What changes did you make?
ready for merge team
label instead of theready for dev lead
label.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
For Reviewers
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)