Fix Total Message Count Calculation to Account for Headers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviasculley
approved these changes
Dec 10, 2023
|
Thank you, @oliviasculley! This should hopefully also lessen the impact of #48 while work is done to get the new Events API stood up.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Summary
Takes into account the headers added to each post (ex: "HackGreenville Events for the week of December 10 - 1 of 2") whenever calculating the total numbers of messages that will be needed in order to contain all of the events for a given week.
I chose 61 as the character count for the buffer to handle the longest header I'd anticipate seeing:
HackGreenville Events for the week of September NN - YY of ZZBefore/After For the Week of December 10th: