Update Dependencies - Feb 2024 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The middleware workaround was put in place due to an issue where calling await req.body() within middleware would cause the thread to become blocking. This would cause Starlette to throw and exception. This is no longer an issue and can safely be removed.
ThorntonMatthewD
force-pushed
the
update-dependencies-feb-2024
branch
from
c591afb to
b9799c7
Compare
oliviasculley
approved these changes
Feb 5, 2024
| @API.middleware("http") | ||
| async def rate_limit_check_api( | ||
| req: Request, call_next: Callable[[Request], Awaitable[None]] | ||
| ): | ||
| """Looks to see if /check_api has been run recently, and returns an error if so.""" | ||
| req_body = await get_body(req) | ||
| req_body = await req.body() |
There was a problem hiding this comment.
I wish there was a chef's kiss emoji for this!
There was a problem hiding this comment.
It felt so good to rip that out, oh my gosh!
ThorntonMatthewD
commented
Feb 5, 2024
| { name = "Olivia Sculley", email = "[email protected]" }, | ||
| ] | ||
| keywords = [ | ||
| "automation", |
There was a problem hiding this comment.
I didn't mean to reformat this entire file. I was fighting with my autolinter hard, and I think it won.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description