Update footer and navbar styles to match MUI v6 #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is something that got fixed in a previous commit from July 17th, but it still crept back up on this branch somehow. Removed unused imports.
I don't fully understand if the jsconfig file is needed for projects that don't use typescript. It has something to do with intellisense. At least removing this line gets rid of type errors.
The CSS injected last gets higher priority, and as Tailwind is built on top of MUI, it only makes sense to give Tailwind a higher priority. A similar fix was previously added in a commit from February 13, 2024 and subsequently removed on June 23, leaving me to wonder why I was not able to override MUI styles.
Made an effort to get rid of the divider component as well.
Haven't touched most variants, only remember making edits to contained, outlined and outlinedNew.
Also made them scalable with bigger fonts.
julisod
changed the title
This reverts commit 00f87a1, since Tailwind will no longer be relevant.
|
Now the navbar shouldn't contain any tailwind classes. I also added an extra breakpoint because I think it looks nicer instead of directly jumping to all elements being in a column.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footer pics