forked from ethereumclassic/explorer
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackmod token fixes #2
Open
benjioh5
wants to merge
56
commits into
hackmod:token-fixes
Choose a base branch
from
benjioh5:hackmod-token-fixes
base: token-fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev into Master
ethereumproject >> ethereumclassic
Added ONEX Network token, ERC223 PoS token created on Ethereum Classic Network
Update token.json
Add docker-compose config
Rename to ethereumclassic
to match with github
* no maintainers to maintain dao support & no one is viewing it
* they aren't being maintained for years and no one use them * updated custom.css to fix search bar on mobile
normalize expressions for other supported node clients
such a poor naming sense for `blockDB` 😂
* make web3relay.js read from db * use Gwei unit for gasPrice * improve tx page * format tx into normalizeTX by @hackmod * web3 tx fetch by @hackmod * fetch tx.status and tx.gasUsed information from getTransactionReceipt * etherscan.io style fix * added block confirmation for tx * added tx fee ( gasused * gasprice ) * added missing db index * fix uncle block search by @naikmyeong
cherry picked from EthereumCommonwealth/clo-explorer@c4502a0 by @yograteol * configurable fiat conversion * hide fiat value when it is not used. * use cryptocompare instead of coinmarketcap
* replace rpc port to websocket ( better performance & stability ) * use async, rebased listenBlocks for latest ws connection * modifications to match latest web3 api ( web3.eth.getBlockNumber, web3.eth.net.isListening ) * use web3.eth.subscribe to fetch latest blocks * added custom web3-explorer package to connect with parity-only api * roll backed web3.batch due to lack of technical support
* add support for geth - rpc tx * record contract on db * record erc20 token transfers on db * enable quiet mode for tools/sync.js - reduce logging
* merge tools/price.js into tools/sync.js * price ticker enabled by default * remove unused patcher.js and blockHelper.js from tools folder
* remove dead code ( web3dummy ) * remove duplicated app.js file
not being used since it has its docker running
* follow 2 spaces rules that is described on html-formatter
address review by @hackmod
* remove internal tx table field as they are shown on main table already
* to-do do the same thing for other contracts
Various improvements ( tx page, sync, load ) & codebase cleanup
Backport: Dev into Master
require node 8 to build
…rfile Update Dockerfile
Bumps [tree-kill](https://github.com/pkrumins/node-tree-kill) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/pkrumins/node-tree-kill/releases) - [Commits](pkrumins/node-tree-kill@v1.2.1...v1.2.2) Signed-off-by: dependabot[bot] <[email protected]>
…t/npm_and_yarn/tree-kill-1.2.2 build(deps): bump tree-kill from 1.2.1 to 1.2.2
테스트 중인데... 수정할게 좀 많네요... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETC 팀 측에서 ERC20 피쳐 관련해서 머지 안 하고, 그냥 쭉 개발해서 수정 분 올립니다. 제가 기능 동작을 제대로 이해했는지 리뷰 좀 가능하실까요? (2018년 이후로 좀 많이 바뀐 거 같더라고요)