fix for GfpGAN and inswapper model path retrieval bug

[NeuroDonu]

Hi. not too long ago i was getting the error that is described in this issue: #770
I added a fix for this bug (it was a misconstructed path)

Summary by Sourcery

Bug Fixes:

• Fix incorrect model path retrieval for GfpGAN and inswapper models by constructing absolute paths.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR fixes path resolution issues for the GfpGAN and inswapper models by replacing relative path resolution with absolute path construction. The implementation uses os.path functions to reliably construct paths to the models directory, eliminating platform-specific path handling and potential path resolution errors.

Class diagram for face_enhancer.py and face_swapper.py changes

classDiagram
    class FaceEnhancer {
        +THREAD_LOCK
        +NAME
        +abs_dir
        +models_dir
        +pre_check() bool
        +get_face_enhancer() Any
    }
    class FaceSwapper {
        +THREAD_LOCK
        +NAME
        +abs_dir
        +models_dir
        +pre_check() bool
        +get_face_swapper() Any
    }
    note for FaceEnhancer "Updated path resolution for model_path using os.path.join"
    note for FaceSwapper "Updated path resolution for model_path using os.path.join"

Loading

File-Level Changes

Change	Details	Files
Implemented absolute path resolution for model files	Added absolute path construction using os.path.dirname and os.path.abspath Created a models_dir variable to store the absolute path to the models directory Removed platform-specific path handling for Windows Replaced resolve_relative_path calls with os.path.join for model file paths	modules/processors/frame/face_enhancer.py modules/processors/frame/face_swapper.py
Removed dependency on resolve_relative_path utility	Removed resolve_relative_path import in face_swapper.py Added os module import for path handling	modules/processors/frame/face_swapper.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @NeuroDonu - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the models directory path construction logic into a shared utility function or configuration file to avoid duplication across face_enhancer.py and face_swapper.py

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}