-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsizes on mutations #315
Conversation
5c502cf
to
77c7c24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Two comments.
I noticed that running tests fails because of js_of_ocaml
. This is unrelated to this PR (probably introduced in #265), but something we need to get fixed. Manually installing it fixes the issue
File "bin/dune", line 27, characters 28-39:
27 | (libraries zarith_stubs_js js_of_ocaml lib))
^^^^^^^^^^^
Error: Library "js_of_ocaml" not found.
fb1ecbf
to
61c4366
Compare
I fixed the field bug, and added the example you suggested @franziskuskiefer :) |
61c4366
to
e967a3a
Compare
And you force pushed ... So this will have to wait until tomorrow I'm afraid because I have to start the review from scratch |
Sorry... I'm so used to running |
2f367b8
to
2ee26c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
CI is failing |
eb456c2
to
8bad5fb
Compare
Fixes #256:
copy_from_slice
(and any other functions with &mut inputs actually) on sized things (e.g. fixed size arrays[T; N]
)This is related to thin / fat pointers.
cc @karthikbhargavan @xvzcf @geonnave