Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[attract] module #1034

Closed
wants to merge 6 commits into from
Closed

[attract] module #1034

wants to merge 6 commits into from

Conversation

AnnaKravchenko
Copy link
Contributor

@AnnaKravchenko AnnaKravchenko commented Sep 18, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

So far [attract] module can:

  • Make sure ATTRACT is installed
  • Coarse-grain protein and RNA
  • Fragment RNA and prepare required for ATTRACT files.

It requires strictly 1 protein and 1 RNA molecules as an input.

Installation guidlines are inhaddock3/src/haddock/modules/sampling/attract/install.md

Related Issue

#1027

Additional Info

Currently required environment variables:

$ATTRACTDIR=/trinity/login/arha/tools/attract/bin
$ATTRACTTOOLD=/trinity/login/arha/tools/attract/tools
$LIBRARY=/trinity/login/arha/tools/nalib 
$RANDSEARCH=/trinity/login/arha/data/ssRNA/randsearch

If you import these variables - [attract] may run* on tintin.
*now only create required by ATTRACT folder structure and pass two models to the next module

…ract CG 3/ add required by attract files to working directory
@AnnaKravchenko AnnaKravchenko self-assigned this Sep 18, 2024
@AnnaKravchenko AnnaKravchenko linked an issue Sep 18, 2024 that may be closed by this pull request
@AnnaKravchenko AnnaKravchenko added enhancement Enhancing an existing feature of adding a new one feature New feature request labels Sep 18, 2024
@rvhonorato rvhonorato added m|attract and removed enhancement Enhancing an existing feature of adding a new one labels Sep 18, 2024
@AnnaKravchenko
Copy link
Contributor Author

AnnaKravchenko commented Sep 18, 2024

  • Add instructions on how to install ATTRACT
  • Move small functions in separate .py
  • Move 'nalib check' to ‘general installation check’ with corresponding message
  • Try to do all I need to do with pdb within 1 function (to not open/close file multiple time)
  • Use sys.executable rather than subprocess.run
  • Be more consistent with the style (particularly replace open(file,'r’) with with open(file,w) as)
  • Think if it can/should be a class?
  • ! Check if python3 (‘def') in attract is compatible with python3 of haddock3 (‘hdd3’)

@rvhonorato rvhonorato changed the base branch from main to attract-module September 20, 2024 12:26
@AnnaKravchenko AnnaKravchenko marked this pull request as ready for review October 2, 2024 12:14
@AnnaKravchenko AnnaKravchenko deleted the attract branch October 2, 2024 12:27
@AnnaKravchenko AnnaKravchenko mentioned this pull request Oct 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request m|attract
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[attract] as a sampling module
2 participants