Skip to content

Commit

Permalink
(BREAKING) Apply planned breaking changes as specified in the AAC V1 …
Browse files Browse the repository at this point in the history
…release:

- As specified in the changelog for the official release of Animator As Code V1, breaking changes had been planned, and will be applied starting this version:
  - (BREAKING) AacFlSettingKeyframes constructor is now private.
    - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x.
  - (BREAKING) The methods AacFlBase.InternalConfiguration and AacFlBase.InternalDoCreateLayer are now private.
    - For compatibility reasons, it was public for the duration of V1.1.x, and was already marked as obsolete in V1.1.x.
    - The class AacAccessorForExtensions replaced them.
  • Loading branch information
hai-vr committed Nov 29, 2024
1 parent e445ba8 commit ff681e6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions Packages/dev.hai-vr.animator-as-code.v1/V1/Editor/Aac.cs
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,9 @@ public class AacFlBase
{
private readonly AacConfiguration _configuration;

/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved
[Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")]
public AacConfiguration InternalConfiguration()
/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.AccessConfiguration
[Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.AccessConfiguration(...) instead")]
internal AacConfiguration InternalConfiguration()
{
return _configuration;
}
Expand Down Expand Up @@ -583,9 +583,9 @@ public AacFlController NewAnimatorController(string name)
/// Destructive workflow: Clears the topmost layer of an arbitrary AnimatorController, and returns it.
public AacFlLayer CreateFirstArbitraryControllerLayer(AnimatorController controller) => DoCreateLayer(controller, controller.layers[0].name);

/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Maybe this can be improved
[Obsolete("This will be made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")]
public AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName)
/// NOT FOR PUBLIC USE: Internal use only so that destructive workflow can access this. Has been replaced with AacAccessorForExtensions.CreateLayer
[Obsolete("This has been made private/internal in V1.2.0. Use AacAccessorForExtensions.CreateLayer(...) instead")]
internal AacFlLayer InternalDoCreateLayer(AnimatorController animator, string layerName)
{
return DoCreateLayer(animator, layerName);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -649,8 +649,8 @@ public class AacFlSettingKeyframes
private readonly List<Keyframe> _mutatedKeyframes;

// Will be made private/internal in V1.2.0.
[Obsolete("This will be made private/internal in V1.2.0")]
public AacFlSettingKeyframes(AacFlUnit unit, List<Keyframe> mutatedKeyframes)
[Obsolete("This has been made private/internal in V1.2.0")]
internal AacFlSettingKeyframes(AacFlUnit unit, List<Keyframe> mutatedKeyframes)
{
_unit = unit;
_mutatedKeyframes = mutatedKeyframes;
Expand Down

0 comments on commit ff681e6

Please sign in to comment.