Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Remove unused and redundant requirements #13988

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

daniel-goldstein
Copy link
Contributor

asyncinit is unused AFAICT and the frozenlist requirement is already inherited from hailtop (though it is not used in hailtop only in query code, so am also happy to move it out of hailtop fully and into query).

Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about this no longer typechecks, but fix that and this change is good to go.

@danking danking merged commit 258b26f into hail-is:main Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants