Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passes --public-ip-address to hailctl dataproc start #14653

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Passes --public-ip-address to hailctl dataproc start #14653

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
940b1b1
Add support for public-ip-address in dataproc (#346)
illusional Aug 5, 2024
91706bf
set internal-ip-address to true by default and lint
iris-garden Aug 5, 2024
2fa582d
no option, just add the flag to the command
iris-garden Aug 6, 2024
c5f3174
Merge branch 'main' into hailctl/dataproc/internal-ip
iris-garden Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hail/python/hailtop/hailctl/dataproc/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,12 @@ def start(
debug_mode: Ann[
bool, Opt(help='Enable debug features on created cluster (heap dump on out-of-memory error)')
] = False,
public_ip_address: Ann[
bool,
Opt(
help='Allow nodes to have a public IP address, and hence make requests on the public internet (default is internal-only from dataproc 2.2).'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your description:

since we need internet access to install some of our dependencies

Is there any use case where someone would want to disable public IP addresses and not have the dependencies set up? If not, should this just be forced to be true (instead of being an option)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, looks like we get the list of dependencies from hail/python/hailtop/hailctl/deploy.yaml, which is generated when we build the wheel, so there is not a way for the user to avoid using the packages we specify. Revised to just make this part of the command string instead of an option!

),
] = True,
):
"""
Start a Dataproc cluster configured for Hail.
Expand Down Expand Up @@ -243,6 +249,7 @@ def start(
requester_pays_allow_annotation_db,
debug_mode,
use_gcloud_beta,
public_ip_address,
)


Expand Down
3 changes: 3 additions & 0 deletions hail/python/hailtop/hailctl/dataproc/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ def start(
requester_pays_allow_annotation_db: bool,
debug_mode: bool,
beta: bool,
public_ip_address: bool,
):
conf = ClusterConfig()
conf.extend_flag('image-version', IMAGE_VERSION)
Expand Down Expand Up @@ -395,6 +396,8 @@ def jvm_heap_size_gib(machine_type: str, memory_fraction: float) -> int:
cmd.append('--expiration_time={}'.format(expiration_time))
if service_account:
cmd.append('--service-account={}'.format(service_account))
if public_ip_address:
cmd.append('--public-ip-address')

cmd.extend(pass_through_args)

Expand Down