Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sentence structure for closing tag omit #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidneyshafer
Copy link

Update English README.md file. Changed sentence structure to read better.

@StackOverflowIsBetterThanAnyAI

This PR should really be merged because it changes the meaning of the sentence entirely (in a very good way).

@hail2u
Copy link
Owner

hail2u commented May 3, 2024

There is no “the rule for not omitting a closing tag”.

@sidneyshafer
Copy link
Author

The rule itself states that you should not omit HTML closing tags. The definition of omit means to leave out or exclude. Therefore, we should not leave out out or exclude closing tags. Right now, you have it as "I think you don’t understand a rule for omitting closing tag". Your statement reads as though you think we don't understand a rule for leaving out (or excluding ) a closing tag. By changing the sentence to "I think you understand the rule for not omitting a closing tag", you are explaining to the reader that you should not leave out or exclude a closing tag when it is necessary. Alternatively, you could also change the sentence to something like "I think you should understand the rule for including a closing tag". To "not omit" is to include, and to "omit" is to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants