Fallback to Table's Converters to format cell values #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallback to the Table's original converters if available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each implementation (Excel, CSV and PDF) decide how to handle each cell value.
If the table has columns with converters, they are ignored and a toString is used.
This change introduces the following behavior:
If the exporter implementation knows how to handle the value class (for example, if it's a Date, ExcelExporter can format the cell as date value), nothing changes and it should still use the original value.
If the implementation has no specific way to handle that class, and the table has converters set for that column, the exporter implementation has the option of using this "presentation value" as converted by the Converter.