Use argparse in searpc-codegen for basic --help #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moschlar
force-pushed
the
searpc-codegen-help
branch
from
7705504 to
4e9ed72
Compare
caixiangyue
force-pushed
the
master
branch
4 times, most recently
from
fe1e1e5 to
c5d031e
Compare
|
Ping @feiniks !? |
moschlar
force-pushed
the
searpc-codegen-help
branch
from
26317fc to
b113ca4
Compare
killing
reviewed
Oct 31, 2024
| @@ -176,11 +176,16 @@ def gen_signature_list(): | |||
| write_file(f, generate_signature(item[0], item[1])) | |||
|
|
|||
| if __name__ == "__main__": | |||
| import argparse | |||
| parser = argparse.ArgumentParser(description='Generate function signatures and marshals for using Searpc') | |||
| parser.add_argument('rpc_mod_file', nargs='?', help='the RPC module file name (default: rpc_table)') | |||
There was a problem hiding this comment.
I think nargs is not necessary since this is a positional argument, not a flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an argparse block to searpc-codegen for basic
--helpoutput