small fixes #69
Open
small fixes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following problems: - Since searpc-signature.h and searpc-marshal.h are built by the same command, the grouping operator `&` is needed for the parallel build to work correctly. Otherwise `make` will try to execute the recipe in parallel for both headers, while only 1 execution is desired. - For out-of-tree builds the prerequisite must be referred with `$<`. - Don't explicitly use `python` command, as it may be `python3` on some distros. Instead rely on the correct "shebang" string.
|
There is also the problem that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that I am using libsearpc
provided by fedora, not from this repo.
I hope these patches are valid anyway.