Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link plugin #23

Merged
merged 6 commits into from
Oct 8, 2023
Merged

Link plugin #23

merged 6 commits into from
Oct 8, 2023

Conversation

libra-co
Copy link
Contributor

  1. link plugin

shuntian
shuntian reviewed Oct 7, 2023
View reviewed changes
src/extension/plugins/link/render-elem/index.js Outdated
// Only on popover can be open at the same time, close other popover and update new popover controller function.
const eventBus = EventBus.getInstance();
eventBus.dispatch('closeLinkPopover');
eventBus.subscribe('closeLinkPopover', () => setIsShowPopover(false));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方再思考一下怎么实现

@shuntian shuntian merged commit a5e9760 into main Oct 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuntian shuntian shuntian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libra-co @shuntian