Update macOS app icon to fit other Big Sur icons #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Seafile client's app icon doesn't follow the macOS guidelines:
https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon
Since Big Sur was released, all icons should follow a certain template available on the site above. I was going to update it myself but I found someone on macosicons.com who had already created an up to date version here:
https://macosicons.com/u/Malte
Thank you Malte! ❤️
It makes Seafile look 100% consistent with the rest of the icons on the dock!
I also added a second commit which updates the CMake copy command to actually grab the icns file from the project root, not from the working directory. This fixes building when using a build folder.