Optimize the configure options. #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ly1217
force-pushed
the
optimize_configure_options
branch
11 times, most recently
from
daa129f
to
f6c97e9
Compare
killing
reviewed
Oct 10, 2019
common/config-mgr.c
Outdated
| if (strcmp (group, "zip") == 0 && | ||
| strcmp (key, "windows_encoding") == 0) { | ||
| setlocale (LC_ALL, "en_US.UTF-8"); | ||
| } |
There was a problem hiding this comment.
不应该在这里针对一个选项加一些“副作用”逻辑，这些逻辑应该在具体的业务模块里面做。
common/config-mgr.c
Outdated
| } | ||
|
|
||
| cache_key = g_strdup_printf ("%s,%s", group, key); | ||
| cache_value = g_strdup_printf ("%s,%s", value, property); |
There was a problem hiding this comment.
这个哈希表的 value 应该定义一个结构体，key 用 group/key 这种字符串更好。
common/config-mgr.c
Outdated
| return NULL; | ||
| } | ||
| mgr->config_cache = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free); | ||
| load_config_cache (mgr); |
There was a problem hiding this comment.
这个 load_config_cache 应该放在 seaf_cfg_manager_init 函数里面调用。而且不要把对 seaf_cfg_manager_init 函数的调用放在 seaf_cfg_manager_new 函数里面，两个是分开的。
| @@ -7,6 +7,7 @@ typedef struct _SeafCfgManager SeafCfgManager; | |||
| struct _SeafCfgManager { | |||
| GKeyFile *config; | |||
| SeafDB *db; | |||
| GHashTable *config_cache; | |||
| }; | |||
There was a problem hiding this comment.
这个结构体应该只包含一个 SeafCfgMgrPriv 的指针，然后 Priv 这个机构在 .c 文件中定义。一般不要把内部的数据机构暴露在头文件中。
common/fs-mgr.c
Outdated
| @@ -31,8 +31,11 @@ | |||
| #endif /* SEAFILE_SERVER */ | |||
|
|
|||
| #include "db.h" | |||
| #include "../server/fileserver-config.h" | |||
common/fs-mgr.c
Outdated
|
|
||
| #define SEAF_TMP_EXT "~" | ||
| #define DEFAULT_FIXED_BLOCK_SIZE ((gint64)1 << 23) /* 8MB */ | ||
| #define DEFAULT_MAX_INDEXING_THREADS 1 |
| @@ -646,7 +656,7 @@ chunking_worker (gpointer vdata, gpointer user_data) | |||
| if (chunk->result < 0) | |||
| goto out; | |||
|
|
|||
| idx = chunk->offset / seaf->http_server->fixed_block_size; | |||
There was a problem hiding this comment.
所有类似 seaf->http_server->fixed_block_size 这样的配置变量，都应该从结构体中删除，这样才能保证没有漏改的代码。
server/quota-mgr.c
Outdated
| @@ -28,7 +28,7 @@ get_default_quota (SeafCfgManager *mgr) | |||
| gint64 quota; | |||
|
|
|||
| quota_str = seaf_cfg_manager_get_config_string (mgr, "quota", "default"); | |||
| if (!quota_str) | |||
| if (strcmp (quota_str, "-2") == 0) | |||
server/repo-mgr.c
Outdated
| @@ -293,18 +293,11 @@ scan_trash (void *data) | |||
| } | |||
|
|
|||
| static void | |||
| init_scan_trash_timer (SeafRepoManagerPriv *priv, GKeyFile *config) | |||
| init_scan_trash_timer (SeafRepoManagerPriv *priv, SeafileSession *seaf) | |||
ly1217
force-pushed
the
optimize_configure_options
branch
6 times, most recently
from
d60f281
to
a2ddf9c
Compare
ly1217
force-pushed
the
optimize_configure_options
branch
from
a2ddf9c
to
49ee3a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.