Allow upload link to work for subdirectory of upload folder. #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the behavior is such that the directory specified in the two requests have to match, which makes the argument for the second request completely useless. If this were to be the desired behavior then the `parent_dir` parameter should just be ignored from the second request completely. Alternatively, this commit allows upload to a subdirectory of the `p` parameter from the first request again. This matches the old behavior better without allowing uploading to an arbitrary directory. If the current behavior is also desired for some use cases, it should be added as new request or with a new parameter on the first request. Fix regression from haiwen#286. Fix haiwen/seahub#4441
yuyichao
force-pushed
the
upload_parent
branch
from
da78b3b
to
b15baaa
Compare
|
Test failure is expect from the change in the API handling. I can try to fix the test once a decision on what to do with this is made. |
|
Also ref haiwen/seafile-client#1274 for the comment I left about |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the behavior is such that the directory specified in the
two requests have to match, which makes the argument for the second
request completely useless. If this were to be the desired behavior
then the
parent_dirparameter should just be ignored from the secondrequest completely. Alternatively, this commit allows upload to a subdirectory
of the
pparameter from the first request again.This matches the old behavior better without allowing uploading to
an arbitrary directory.
If the current behavior is also desired for some use cases,
it should be added as new request or
with a new parameter on the first request.
Fix regression from #286.
Fix haiwen/seahub#4441