New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔍 review contract #1

Open

GabrielAstieres wants to merge 1 commit into main from review

Collaborator

GabrielAstieres commented Sep 18, 2023

Had a quick look at the contract:

Nice re-implem of owner, but careful when not using known libs.
With payable functions, you are in a scenario where re-entrency could be an issue if you had public facing function. Best to keep that in mind.
Minor comments in the contract.
An issue with the withdraw function, not able to handle every type of ERC-20, that could lead to a loss of funds.


          🔍 review contract

GabrielAstieres force-pushed the review branch from 1392430 to 2548937 Compare

September 18, 2023 12:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet