Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cocoa, internal/graphicsdriver/metal/*: minimize allocations #3133

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

TotallyGamerJet
Copy link
Contributor

Cache the result of objc.RegisterName at program startup. Use NSInvocation less to avoid multiple C calls

What issue is this addressing?

n/a

What type of issue is this addressing?

performance

What this PR does | solves

Lowers memory usage

Cache the result of objc.RegisterName at program startup. Use NSInvocation less
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hajimehoshi hajimehoshi merged commit 5dee21d into hajimehoshi:main Oct 18, 2024
14 checks passed
@TotallyGamerJet TotallyGamerJet deleted the allocs branch October 18, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants