Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL-1945: fix notification badge visibility #1014

Merged
merged 1 commit into from
Nov 23, 2023
Merged

HAL-1945: fix notification badge visibility #1014

merged 1 commit into from
Nov 23, 2023

Conversation

michpetrov
Copy link
Contributor

Issue: HAL-1945

Port of #1013

@michpetrov
Copy link
Contributor Author

@hpehl do you know how to disable the checkstyle? I've tried multiple variations of @SuppressWarnings("MultipleStringLiterals") but it keeps failing.

@hpehl
Copy link
Member

hpehl commented Nov 23, 2023

Sorry, I thought @SuppressWarnings("MultipleStringLiterals") should work. I remember fighting with checkstyle as well and ending up replacing " " with something like private final static String BLANK = " ";

I know that's silly, but I didn't find anything better 🤷‍♂️

@hpehl
Copy link
Member

hpehl commented Nov 23, 2023

Thanks @michpetrov

@hpehl hpehl merged commit ac4e35b into hal:3.3.x Nov 23, 2023
5 checks passed
@michpetrov michpetrov deleted the hal-1945-port branch November 23, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michpetrov @hpehl