Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arbitrary file access during archive extraction ("Zip Slip") #1215

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

emanuelaepure10
Copy link
Contributor

Ensure that output paths constructed from zip archive entries are validated to prevent writing files to unexpected locations.

ING-4369

@florianesser
Copy link
Member

@emanuelaepure10 One general comment on commit messages: in the commit message subject (= the first line), the part after the commit type - in this case arbitrary file access during archive extraction ("Zip Slip") - should start with a verb in imperative mood, e.g. replace, change, fix or avoid. So a better message in this case would be:

fix: avoid arbitrary file access during archive extraction ("Zip Slip")

@kapil-agnihotri kapil-agnihotri added the challenged For PRs to indicate that the implementation has been challenged label Jul 12, 2024
Ensure that output paths constructed from zip archive entries are validated to prevent writing files to unexpected locations.

ING-4369
@emanuelaepure10 emanuelaepure10 merged commit 5c82a4b into halestudio:master Jul 12, 2024
8 checks passed
@stempler stempler deleted the fix/ING-4369 branch July 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenged For PRs to indicate that the implementation has been challenged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants