feat(arm): remove rocksDB compatibility with LevelDB #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
changed the title
halibobo1205
force-pushed
the
feat/remove_unsafe_mode_for_dbConvert
branch
from
24ca309
to
380fc45
Compare
for later updating RocksDB
halibobo1205
force-pushed
the
feat/remove_unsafe_mode_for_dbConvert
branch
from
380fc45
to
947de69
Compare
halibobo1205
changed the title
| @@ -172,7 +172,12 @@ public void setDBName(String name) { | |||
| public boolean checkOrInitEngine() { | |||
| String dir = getDbPath().toString(); | |||
| String enginePath = dir + File.separator + "engine.properties"; | |||
|
|
|||
| File currentFile = new File(dir, "CURRENT"); | |||
| if (currentFile.exists() && !Paths.get(enginePath).toFile().exists()) { | |||
There was a problem hiding this comment.
I remember that the engine.properties would be added to the LevelDB during the db check in previous versions. Is it necessary to consider this in historical scenarios?
In addition, LevelDB and RocksDB seem to both have the CURRENT files. What is the purpose of this check?
There was a problem hiding this comment.
engine.properties is added by ArchiveManifest tools, not by FullNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for updating RocksDB
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details