Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Minor changes for Zoom #24

Closed
wants to merge 12 commits into from
Closed

Minor changes for Zoom #24

wants to merge 12 commits into from

Conversation

akki-ng
Copy link

@akki-ng akki-ng commented Oct 5, 2016

This will support zoom of image. And ActivityIndicator has been added as AndroidProgressBar is deprecated. Readme.md changes can be ignored as they were meant for internal audience.

@7kfpun
Copy link

7kfpun commented Oct 6, 2016

Android only?

@akki-ng
Copy link
Author

akki-ng commented Oct 6, 2016

Yes, for android only. I've tested these changes on Android and it works fine.

@7kfpun
Copy link

7kfpun commented Oct 6, 2016

I tested on iOS, the images could not show.

@akki-ng
Copy link
Author

akki-ng commented Oct 6, 2016

Okay, I'll check these on iOS and do updates if needed. Meanwhile can you confirm it to work on Android as I did not find any issues for Android.

[Tip]

While installing this module we must install the below module too in MainApplication, Settings.gradle, Build.gradle too.

https://www.npmjs.com/package/react-native-image-zoom

@akki-ng
Copy link
Author

akki-ng commented Oct 6, 2016

Did you put necessary entries into the concerned files for react-native-image-zoom ?

@ksti
Copy link

ksti commented Oct 8, 2016

I'v already add the supporting of zooming photo in this PR, it works with both Android and iOS. Although it hasn't been accepted yet. Why don't you try this?:)

@akki-ng
Copy link
Author

akki-ng commented Oct 8, 2016

@ksti Sure, I will try this soon. Thanks.

@akki-ng
Copy link
Author

akki-ng commented Oct 14, 2016

@ksti I've found an issue with this change. Please ignore the pull request for now.

@akki-ng akki-ng closed this Oct 14, 2016
@akki-ng akki-ng reopened this Oct 14, 2016
@akki-ng akki-ng closed this Oct 14, 2016
@akki-ng
Copy link
Author

akki-ng commented Oct 14, 2016

Close as new pull request is being made.

@akki-ng akki-ng reopened this Oct 14, 2016
@akki-ng akki-ng closed this Oct 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants