Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default kubeconfig to ~/.kube/config #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

default kubeconfig to ~/.kube/config #49

wants to merge 2 commits into from

Conversation

hall
Copy link
Owner

@hall hall commented Dec 10, 2023

closes #46

@hall hall linked an issue Dec 10, 2023 that may be closed by this pull request
kubeconfig: unbound variable #46
Open
@hall hall force-pushed the 46-kubeconfig-unbound-variable branch from 9832b1e to 90924eb Compare December 10, 2023 15:24
@hall hall force-pushed the 46-kubeconfig-unbound-variable branch from 90924eb to 09b7d9b Compare December 10, 2023 15:26
hall
hall commented Dec 10, 2023
View reviewed changes
modules/k8s.nix Show resolved Hide resolved
@zarelit
Copy link

zarelit commented Dec 10, 2023

I've branched from this PR and added a guard to not override KUBECONFIG coming from the user environment: #50

The quotation is tricky because it's inside runCommand and inside nix, the rendered script becomes:

export KUBECONFIG=${KUBECONFIG:-asd} when kubeconfig = asd

@hall
Copy link
Owner Author

hall commented Jan 21, 2024

Thanks @zarelit! Apologies for sitting on it so long but your change looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeconfig: unbound variable
2 participants
@hall @zarelit