Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing shabang in kubenix script #60

Closed
wants to merge 1 commit into from
Closed

add missing shabang in kubenix script #60

wants to merge 1 commit into from

Conversation

adrian-gierakowski
Copy link
Contributor

@adrian-gierakowski adrian-gierakowski commented Mar 25, 2024 •
edited
Loading

fixes #59

needs: #58 to work on 2.21

@adrian-gierakowski
Copy link
Contributor Author

btw. it would probably be better to just use writeShellScriptBin or writeShellApplication to create that script (the latter has the benefit of running shellcheck on the scripts body)

@adrian-gierakowski
Copy link
Contributor Author

check fails since we need to merge #58 first and then rebase

@hall
Copy link
Owner

hall commented Mar 26, 2024

writeShellApplication sounds reasonable to me. Want to go that route instead?

@pizzapim pizzapim mentioned this pull request May 5, 2024
Merged
@hall
Copy link
Owner

hall commented May 8, 2024

Closing since this was addressed in #62.

@hall hall closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubenix script has no shebang, leading to "Exec format error"
2 participants
@adrian-gierakowski @hall