Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use gravatar source as comment's avatar #111

Merged
merged 16 commits into from
Apr 9, 2024
Merged

feat: use gravatar source as comment's avatar #111

merged 16 commits into from
Apr 9, 2024

Conversation

ShiinaKin
Copy link
Contributor

@ShiinaKin ShiinaKin commented Apr 3, 2024 •
edited by ruibaby
Loading

后端改动：halo-dev/halo#5642

Fixes #97
Fixes #77

两个不同邮箱，相同头像

效果：
image

评论头像支持使用 Gravatar 源

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 3, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby April 3, 2024 19:56
@ShiinaKin ShiinaKin changed the title feat: use gravatar source as comment's avatar WIP: feat: use gravatar source as comment's avatar Apr 4, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@ShiinaKin
Copy link
Contributor Author

@JohnNiang @ruibaby 需要一些协助
请看一下自定义模型是否存在问题，以及组件设置界面的编写流程，这个项目好像没有引入vue

@ShiinaKin ShiinaKin requested a review from guqing April 4, 2024 14:47
@ShiinaKin ShiinaKin changed the title WIP: feat: use gravatar source as comment's avatar feat: use gravatar source as comment's avatar Apr 4, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2024
@ShiinaKin
Copy link
Contributor Author

@ruibaby @guqing pls review

@ShiinaKin ShiinaKin requested a review from guqing April 8, 2024 07:37
@ShiinaKin ShiinaKin requested a review from guqing April 8, 2024 07:46
ruibaby
ruibaby requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @mashirot 的贡献，我已经实际测试，功能没有问题。但还有部分建议改进的地方，有时间可以看看。

packages/comment-widget/src/avatar/providers/gravatar.ts Outdated Show resolved Hide resolved
src/main/resources/extensions/settings.yaml Outdated Show resolved Hide resolved
src/main/resources/extensions/settings.yaml Outdated Show resolved Hide resolved
src/main/resources/extensions/settings.yaml Outdated Show resolved Hide resolved
src/main/resources/extensions/settings.yaml Outdated Show resolved Hide resolved
src/main/resources/extensions/settings.yaml Outdated Show resolved Hide resolved
packages/comment-widget/src/user-avatar.ts Outdated Show resolved Hide resolved
packages/comment-widget/src/avatar-provider.ts Outdated Show resolved Hide resolved
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 8, 2024
@ShiinaKin ShiinaKin requested a review from ruibaby April 8, 2024 12:17
@ruibaby
format code
09723eb 
Signed-off-by: Ryan Wang <[email protected]>
ruibaby
ruibaby reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

已测试，符合预期。

再次感谢 @mashirot 的贡献，这帮助社区解决了从 Halo 2.0 到现在的一个问题。

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@JohnNiang JohnNiang requested a review from ruibaby April 9, 2024 02:29
JohnNiang
JohnNiang approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for your first contribution!

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ccae3d2 into halo-dev:main Apr 9, 2024
4 checks passed
@ruibaby ruibaby mentioned this pull request Apr 9, 2024
Open
@JohnNiang
Copy link
Member

当前 PR 可能缺少对于 Halo 版本（>= 2.15）的限制。

@ShiinaKin ShiinaKin deleted the issue-97 branch April 9, 2024 05:27
@ruibaby ruibaby mentioned this pull request May 7, 2024
Open
@mjsoftking mjsoftking mentioned this pull request May 7, 2024
Merged
@ruibaby ruibaby mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

评论组件是否可以增加 Gravatar 源设置 Gravatar 能自定义镜像服务器吗?
4 participants
@ShiinaKin @JohnNiang @ruibaby @guqing