Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace plugin wrapper with plugin context #136

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jun 27, 2024

What this PR does?

替换插件中对于 PluginWrapper 的引用,这是已经过时的引用,这将在后续被移除

None

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby June 27, 2024 08:29
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2024
# Conflicts:
#	src/main/java/run/halo/comment/widget/DefaultCommentWidget.java
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link

f2c-ci-robot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 35ab602 into halo-dev:main Jul 4, 2024
4 checks passed
@guqing guqing deleted the chore/plugin-main branch July 4, 2024 03:21
ruibaby pushed a commit to ruibaby/plugin-comment-widget that referenced this pull request Aug 8, 2024
### What this PR does?
替换插件中对于 PluginWrapper 的引用,这是已经过时的引用,这将在后续被移除

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants