Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension design and registration #3

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

CaiHaosen
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

此 PR 完成了代码的自模型定义和注册

Which issue(s) this PR fixes:

Fixes #2

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. labels Jul 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby July 2, 2024 01:34
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link

f2c-ci-robot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 6cc79e2 into halo-sigs:main Jul 4, 2024
2 checks passed
guqing pushed a commit to guqing/plugin-injection that referenced this pull request Sep 30, 2024
#### What type of PR is this?
/kind feature
#### What this PR does / why we need it:
此 PR 完成了代码的自模型定义和注册
#### Which issue(s) this PR fixes:
Fixes halo-sigs#2 
#### Does this PR introduce a user-facing change?
```release-note
None
```
CaiHaosen added a commit that referenced this pull request Oct 9, 2024
#### What type of PR is this?
/kind feature
#### What this PR does / why we need it:
此 PR 完成了代码的自模型定义和注册
#### Which issue(s) this PR fixes:
Fixes #2 
#### Does this PR introduce a user-facing change?
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

代码片段自定义模型设计
2 participants