Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show plugin settings modal when share url is not config #24

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 2, 2024

支持在进入 Umami 页面时检查是否配置 Umami 共享链接,如果没有配置,则弹出插件设置界面引导用户设置。

image

/kind feature

支持在未设置共享链接时,自动打开插件设置界面。

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang July 2, 2024 09:41
Signed-off-by: Ryan Wang <[email protected]>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
Copy link

f2c-ci-robot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 1fda9c3 into halo-sigs:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants