Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rss telemetry recorder implementation #30

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Dec 6, 2024

What this PR does?

添加 RSS 内容阅读量上报

支持将来自 RSS 的内容阅读量上报到 Umami

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 6, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby December 6, 2024 10:00
Copy link

f2c-ci-robot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from guqing. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guqing guqing force-pushed the feature/rss-telemetry branch 4 times, most recently from 326299f to 630496f Compare December 10, 2024 06:45
@guqing guqing marked this pull request as ready for review December 10, 2024 07:04
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 10, 2024
@guqing
Copy link
Member Author

guqing commented Dec 10, 2024

/hold
wait for halo-dev/plugin-feed#44 to be merged and release

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
f2c-ci-robot bot pushed a commit to halo-dev/plugin-feed that referenced this pull request Dec 10, 2024
…y content views (#44)

### What this PR does?

传统网站即使使用 Umami 等访问统计工具,也难以覆盖 RSS 订阅用户的阅读行为,导致访问量数据不完整,影响对内容表现的准确评估。为解决这一短板,我们新增了在 RSS 订阅中统计访问量的功能支持。

通过在每个 RSS 条目的内容中插入 1 像素透明图片,系统可匿名统计订阅内容的实际阅读量。这种轻量化设计不会影响用户体验,帮助内容创作者更全面的了解内容阅读量情况。

Umami 适配参考 halo-sigs/plugin-umami#30

```release-note
为 RSS 订阅内容统计访问量提供扩展支持,本插件并不提供任何存储和分析访问量的功能但允许其他插件扩展并获取访问量数据上报给诸如 Umami 之类的应用
```
@guqing guqing force-pushed the feature/rss-telemetry branch 2 times, most recently from cd09d02 to 7fe53ba Compare December 10, 2024 14:48
@guqing guqing force-pushed the feature/rss-telemetry branch from 7fe53ba to 817834d Compare December 10, 2024 14:50
@guqing
Copy link
Member Author

guqing commented Dec 10, 2024

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@guqing guqing merged commit 196a36d into main Dec 10, 2024
1 of 2 checks passed
@guqing guqing deleted the feature/rss-telemetry branch December 10, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant