Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contains/containsInAnyOrder overloading issue #317

Closed
wants to merge 55 commits into from

Conversation

gokareless
Copy link

@gokareless gokareless commented Sep 5, 2020

Fixes #301.

Caused:

  • Matcher instantiation depends of actual object type

Fix:

  • Adjusted API to work with arrays embedded in objects

The assumption is that whenever we get to the contains(T... items) with an array, the only possible way to get there with an array is by passing Object type reference (because of contains overloaded methods). Therefore we can safely add extra-check for embedded array

@nhojpatrick
Copy link
Member

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch v2.3-candidates.
Still trying to understand how has permissions to perform a release.

nhojpatrick and others added 28 commits February 13, 2022 21:26
Remove Unnecessary Boxing
Explicit type argument T can be replaced with <>
@gokareless gokareless closed this Feb 15, 2022
@gokareless
Copy link
Author

Adjusted in #380 as per @nhojpatrick request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casted Type should not matter for containsInAnyOrder
3 participants