docs(readme): Update AngularFire library size #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @hamedbaatour! I have updated AngularFire to the proper library size. I used the files gzipped but I you want ungzipped I can provide that was well. Also, AngularFire is broken up into separate modules so it's not necessarily 12.9kb that you'll use. Perhaps we should expand the table row to show each module's size. Does AngularFire-Lite break each feature into a separate NgModule?
|
Hey @hamedbaatour! Any updates on this? |
|
Hi @hamedbaatour. Why did you close this? Your README is still incorrectly reporting the size of AngularFire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @hamedbaatour! I have updated AngularFire to the proper library size. I used the files gzipped but I you want ungzipped I can provide that was well.
Also, AngularFire is broken up into separate modules so it's not necessarily 12.9kb that you'll use. Perhaps we should expand the table row to show each module's size.
Does AngularFire-Lite break each feature into a separate NgModule?
Update: I just realized you are using the tarball of the npm module to measure size. This isn't an accurate form of measurement as not everything shipping in the tarball is incldued in your app. AngularFire ships the documentation, README, multiple tsconfigs and package.json files. If we want to measure size, I recommend we use the minified and compressed UMD bundle size of each feature module. Does that sound good?