generated from TheLartians/ModernCppStarter
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Augment coiteration algorithm to handle hashed level during conjunctive merge #19
Closed
Closed
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
8714270
WIP example of compareVector
adam2392 652d8b0
Adding the unit test for coiteration that should work
adam2392 bcbcbe2
Clean diff
adam2392 462dbb0
Update test/source/coiteration_test.cpp
adam2392 7cc42f7
Update test/source/coiteration_test.cpp
adam2392 1969843
Fix unit test based on comments
adam2392 a9dc754
Merge branch 'comparevec' of github.com:adam2392/xsparse into comparevec
adam2392 0c91a0d
Fix unit test based on comments
adam2392 0a35239
Attempt at the right answer
adam2392 8d97006
Clean
adam2392 c0bc015
I think this enables us to store the ordered indices, but does not ye…
adam2392 fc08789
Fix docstring and clean up unit-test
adam2392 eb63b3c
Fix ci and doctest errors
adam2392 0420df3
Merge branch 'main' into comparevec
adam2392 828092a
Add levelproperty to all the levels
adam2392 b5ec7ef
Merge branch 'main' into levelprops
adam2392 aa56276
Try again
adam2392 29f4f7f
Adding unit tests for level property
adam2392 3e0afc4
Clean diff
adam2392 b63b67c
Only check strict property requirements
adam2392 2ac6d71
Fixed unit-tests for dense ordered
adam2392 5e72277
Level to lower-case
adam2392 25c5c2e
Merging level props
adam2392 ddaf8d2
Merge branch 'levelprops' into comparevec
adam2392 f77dd0d
Trying again
adam2392 6a73b73
Fix new design
adam2392 1a6d711
Merge branch 'levelprops' into comparevec
adam2392 8690b48
Fix co-iteration and just get initial design template for getting tup…
adam2392 a379e0b
Trying
adam2392 89ee47d
Merge branch 'main' into comparevec
adam2392 f7d0ed1
Merge main
adam2392 7730adb
Kind of wip
adam2392 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains my initial attempt at: adding a constexpr check at compile time to determine if the coiteration is valid (this assumes that the user converts non-ordered, non-locatable formats to a correct format).
What I'm not sure on now is how to best implement the
locate
logic. That is, we want to somehow given a tuple of levels, determine which of these have locate and instead of advancing the iterator on those levels, we locate into them given a index and pointer.