Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements SystemDateAndTime schema as well as Get and Set operations with tests #71

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Implements SystemDateAndTime schema as well as Get and Set operations with tests #71

merged 20 commits into from
Jul 11, 2024

Conversation

paoloo
Copy link
Collaborator

@paoloo paoloo commented Jul 8, 2024 •
edited
Loading

What and Why?

Schema for SystemDateAndTime and implementation of both SetSystemDateAndTime and GetSystemDateAndTime

Verification Steps

Make changes using Onvif.Devices.SetSystemDateAndTime.request to set and
Onvif.Devices.GetSystemDateAndTime.request to check.

Tested on

  • UNIVIEW
  • Homaxi
  • HIKVISION
  • Axis

@paoloo paoloo requested a review from waranlogesh July 8, 2024 21:02
@paoloo paoloo requested a review from hammeraj as a code owner July 8, 2024 21:02
@paoloo paoloo marked this pull request as draft July 9, 2024 14:11
@paoloo paoloo marked this pull request as ready for review July 11, 2024 14:36
@paoloo paoloo changed the title [WIP] implements SystemDateAndTime schema as well as Get and Set operations Implements SystemDateAndTime schema as well as Get and Set operations with tests Jul 11, 2024
hammeraj
hammeraj approved these changes Jul 11, 2024
View reviewed changes
Copy link
Owner

@hammeraj hammeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@hammeraj hammeraj merged commit b706680 into main Jul 11, 2024
1 check passed
@hammeraj hammeraj deleted the po/set_date_and_time branch July 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waranlogesh waranlogesh waranlogesh left review comments

@yuriploc yuriploc yuriploc left review comments

@hammeraj hammeraj hammeraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paoloo @yuriploc @hammeraj @waranlogesh