Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetNTP #73

Merged
merged 21 commits into from
Jul 19, 2024
Merged

GetNTP #73

merged 21 commits into from
Jul 19, 2024

Conversation

paoloo
Copy link
Collaborator

@paoloo paoloo commented Jul 13, 2024 •
edited
Loading

What and Why

Schema for NTP and implementation of GetNTP

Verification Steps

  • mix test test/devices/get_ntp.exs to test
  • Onvif.Devices.GetNTP.request to get

Tested on

  • AXIS: ✔️
  • HIKVISION: ✔️
  • UNIVIEW: ✔️
  • Dahua: ❌

@paoloo paoloo changed the title [WIP] SetNTP [WIP] GetNTP and SetNTP Jul 17, 2024
@paoloo paoloo changed the title [WIP] GetNTP and SetNTP [WIP] GetNTP Jul 18, 2024
waranlogesh
waranlogesh reviewed Jul 18, 2024
View reviewed changes
lib/devices/ntp.ex Outdated Show resolved Hide resolved
test/devices/fixtures/get_ntp_response.xml Outdated Show resolved Hide resolved
@paoloo paoloo changed the title [WIP] GetNTP GetNTP Jul 18, 2024
@paoloo paoloo marked this pull request as ready for review July 18, 2024 20:24
@paoloo paoloo requested a review from hammeraj as a code owner July 18, 2024 20:24
hammeraj
hammeraj approved these changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@hammeraj hammeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@hammeraj hammeraj merged commit ee551b1 into main Jul 19, 2024
1 check passed
@hammeraj hammeraj deleted the po/set_ntp branch July 19, 2024 14:04
@paoloo paoloo restored the po/set_ntp branch July 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waranlogesh waranlogesh waranlogesh approved these changes

@hammeraj hammeraj hammeraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paoloo @hammeraj @waranlogesh