Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateOSD #80

Merged
merged 5 commits into from
Aug 6, 2024
Merged

CreateOSD #80

merged 5 commits into from
Aug 6, 2024

Conversation

paoloo
Copy link
Collaborator

@paoloo paoloo commented Aug 5, 2024 •
edited
Loading

What and Why

Implementation of CreateOSD

Verification Steps

mix test test/media/ver10/create_osd_test.exs to test
Onvif.Media.Ver10.CreateOSD.request to set

Tested on

AXIS: ✔️
HIKVISION: ✔️
UNIVIEW: ✔️
Dahua: ✔️

@paoloo paoloo requested a review from waranlogesh August 6, 2024 18:09
@paoloo paoloo marked this pull request as ready for review August 6, 2024 19:13
@paoloo paoloo requested a review from hammeraj as a code owner August 6, 2024 19:13
hammeraj
hammeraj approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@hammeraj hammeraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially a note about the dynamic nature of the elements used to set the OSD could help, either inline or a module doc.

@paoloo paoloo merged commit 24af35f into main Aug 6, 2024
1 check passed
@paoloo paoloo deleted the po/create_osd branch August 6, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waranlogesh waranlogesh waranlogesh approved these changes

@hammeraj hammeraj hammeraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paoloo @hammeraj @waranlogesh