Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get[Audio/Video]EncoderConfigurationOptions #82

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

paoloo
Copy link
Collaborator

@paoloo paoloo commented Aug 9, 2024

What and Why

Implementation of the schema, validation and api call for GetAudioEncoderConfigurationOptions and GetVideoEncoderConfigurationOptions.

Verification Steps

git add test/media/ver10/fixtures/get_audio_encoder_configuration_response.xml
Onvif.Media.Ver10.GetAudioEncoderConfigurationOptions.request and
Onvif.Media.Ver10.GetVideoEncoderConfigurationOptions.request

Tested on

Video Audio
Axis ✔️
Uniview ✔️
Hikivision ✔️ ✔️
Dahua ✔️ ✔️

@paoloo paoloo requested a review from waranlogesh August 9, 2024 20:13
Copy link
Collaborator

@waranlogesh waranlogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests

@paoloo paoloo marked this pull request as ready for review August 9, 2024 20:26
@paoloo paoloo requested a review from hammeraj as a code owner August 9, 2024 20:26
@paoloo paoloo merged commit f7e8aa5 into main Aug 9, 2024
1 check passed
@paoloo paoloo deleted the po/av_encoder_cfg branch August 9, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants