[WIP] Upgrade to Hanami 2 #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add .ruby-version file (for Ruby 3)
We should rename it to CSRF (since it's an acronym now in dry-inflector 0.2.1) but CSRF protecting will be brought into hanami and out of the app, so it's not a high priority
Specifically: - dry-system - dry-configurable - dry-inflector
This was temporarily duplicated but it was brought into hanami/controller due to inflector acronym issues See hanami/hanami-2-application-template#33
See hanami/hanami-2-application-template#54 (fourth bullet)
See hanami/hanami-2-application-template#54 (first bullet)
See hanami/hanami-2-application-template#54 (seventh bullet)
We copy the database_cleaner.rb and helpers.rb class from: https://github.com/hanami/hanami-2-application-template/tree/de0ccce5ab98281b2005c9508bd8ba0a679e2660/spec/support/db
|
Just moved the repositories over into the |
No need to use the slice, in preparation for changing it to an instance double
We take a pretty hard stance against monkey patching so we should be consistent. Skipping doesn't add much, and it's more explicit this way.
cllns
force-pushed
the
work-in-progress/upgrade-to-hanami-2
branch
from
6ad0f57
to
6017e85
Compare
The pluging wasn't working when it was in the other location
Thanks to hanami/hanami#1119
It was accidentally wiped out in the initial upgrade effort
Rather than manually deleting via the repository
To match pattern givien in hanami/hanami-2-application-template
This is slightly broken. It should be fixed when dry-rb/dry-auto_inject#77 is merged
Switched to , back to old book and switched to a spy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress.
I used https://github.com/hanami/hanami-2-application-template to base this work off, so there are extra things in this repo from that.
This PR currently uses some GitHub sources in the Gemfile, to get not-yet-released code.
I tried to break the commits up into reasonable chunks, but for many of them the tests just don't pass because there's a lot of configuration that needs to change.
I may rewrite these commits and force-push to rewrite some commit history, so be aware of that.
We will be using this to write an "Upgrading from Hanami 1 to Hanami 2" guide.