New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeclient: getblockheader #28

Merged

boymanjor merged 2 commits into handshake-org:master from tynes:getblockheader

May 8, 2020

Contributor

tynes commented May 1, 2020

Adds a method getBlockHeader to the NodeClient

Based on bcoin-org/bclient#21
Requires handshake-org/hsd#210


          nodeclient: getblockheader

ebce546

tynes mentioned this pull request

node/http: get header by hash/height handshake-org/hsd#210

Merged

Contributor Author

tynes commented May 1, 2020

Copied from handshake-org/hsd#210 (comment)

ACK, would be nice to have CLI update in hs-client as well.

Do you think there should also be a command added like:

$ hsd-cli header <heightOrHash>

Would be happy to add if so. Note that I have another PR to add functionality to the CLI here #18


          hsd-cli: add header command

2a9c1f2

Contributor Author

tynes commented May 7, 2020

@boymanjor The HTTP endpoint has been merged into hsd#master

handshake-org/hsd#210
handshake-org/hsd@3682535

I also added a new command to hsd-cli called header, addressing #28 (comment)

boymanjor approved these changes

View reviewed changes

pinheadmz approved these changes

View reviewed changes

Member

pinheadmz left a comment

Show Signature

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 2a9c1f2835506c4dd3872881b82ec938fdb38b18
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAl61XQUACgkQ5+KYS2KJ
yTqm5w//VNuZn3bwGKxE719L8edaoI9k4C4agnxrSiJnnht3hw1XlqgLkuVJvlWZ
C7XG416L6mnY+/MvcFkXOAFQ6yTOnTVfzaNR+Vrpk1085yF+pUrT6IYoHMDgbyrc
9Nwi4GamkaSiN5JblOk64MYUjc8Hyxa+61l5C1isVw1Oo54w1HlM4on0PUCgGUbG
bTvNfAXmy9y3qRT6U/FfIhoG3UsqS2ooUQrDERG0ruzE4dapK02bXU050Pfs9R5Y
gQyqAbYCUJd37iPJXxeqHJla7/u0hiZVa8cHPxN3L2GJjyYMUcM4oOA0oWugoNvE
HAb43KUP1fDHUnNPmVaqpv6+0WtA96h78FY0zeB/UXn4RTje5S2l84NhFBHvBeIX
1MGgXzDxcYpDrPcZQxVUwwCGmm8sQETgxDJAPiRe94mFvInYsmAUZzzbBQIEYst1
hXEah95eSDsR5p95N5ioo7WjlDlyXu4tvevagsoelWIiq4QOxZKdjJh+rxSC6Y3P
qMeNQhqLdR1wVpfS5t5Xp5ztz/vw0fBMIh8oGFk4gla/+G17f8MPWsjkuOYTcclD
l29lpwJPI+rQn3TY4/h8L6lgO4fu9tpUKl33srs1xM21upL65RQVEm93Re0v1mBE
Ng0vVhOA/uc/ipXG3BTVkVx0gq48JwiROHUHTL9JDgvwfJ9Nhsw=
=5s9v
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

boymanjor merged commit fa31898 into handshake-org:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet