-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bundling Handsontable^7.0.0 #30
base: develop
Are you sure you want to change the base?
Conversation
This commit adds support for bundling Handsontable and Handsontable Pro using new file structure which currently exists on the develop branch. Additionally, in this commit, all dependencies were upgraded to the newest possible version and removed some part of code about detecting modules such as: "validator", "editor" and "renderer". The implementation has never been fully implemented. Issue: #29
This commit fixes issues related to building Handsontable where dist files are incorrectly marked as Pro (commercial license) or as CE (MIT). Additionally, usage description has been updated with the README file. Issue: #29
- [Building Handsontable Community Edition package from the remote repository](https://asciinema.org/a/117465) | ||
- [Building Handsontable Community Edition package from a local directory](https://asciinema.org/a/117464) | ||
- [Building Handsontable package from the remote repository](https://asciinema.org/a/117465) | ||
- [Building Handsontable package from a local directory](https://asciinema.org/a/117464) | ||
- [Building Handsontable PRO package from the remote repository](https://asciinema.org/a/117462) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this line after Handsontable 7.0.0
release.
moduleNamesToExclude.splice(moduleNamesToExclude.indexOf(module.name), 1); | ||
} | ||
|
||
module.getAllDependencies().forEach(function(dependency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe by using Array.filter
the code would be yet more clear ;)? A decision about using it is up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change README after release. Everything else seems to be good.
This commit adds support for bundling Handsontable and Handsontable Pro using new file structure which currently exists on the
develop
branch.Additionally, in this commit, all dependencies were upgraded to the newest possible version and removed some part of code about detecting modules such as: "validator", "editor" and "renderer". The implementation has never been fully implemented.
For reviewers/testers:
develop
branch (https://github.com/handsontable/handsontable/tree/develop) can be used to test this changes;version
key of thepackage.json
file for the Handsontable repository to7.0.0
. Otherwise hot-builder reject the repository (https://github.com/handsontable/hot-builder/pull/30/files#diff-67ac0a10e6fd3203f52f4f88b45db601R8);