Fix missing exported changes when batching operations #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert angular demo to previous version
sequba
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Thank you for this contribution. Good job!
Just a few formalities before we can merge the pull request:
- please add a changelog entry
- please add a unit test that demonstrates the bug (it should fail before applying your fix). File
computation-suspension.spec.tsseems to be the best place for it.
sequba
changed the title
sequba
reviewed
Aug 2, 2023
| @@ -8,7 +8,7 @@ more details. | |||
| ## Demo | |||
|
|
|||
| <iframe | |||
| src="https://codesandbox.io/embed/github/handsontable/hyperformula-demos/tree/2.5.x/angular-demo?autoresize=1 | |||
| src="https://codesandbox.io/embed/github/handsontable/hyperformula-demos/tree/2.4.x/angular-demo?autoresize=1 | |||
There was a problem hiding this comment.
Please pull the latest changes from develop
Codecov Report
@@ Coverage Diff @@
## develop #1294 +/- ##
========================================
Coverage 97.20% 97.20%
========================================
Files 167 167
Lines 14295 14295
Branches 3064 3064
========================================
Hits 13895 13895
Misses 395 395
Partials 5 5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes an issue where the wrong address key was being used (col, row) instead of (row, col).
72862d7#diff-85d401cfd01ec0afae371f4af4e54e3a13cc6bcefe1e2d411671c013acc8a8f6R67-R70
How did you test your changes?
Added two tests, one in
content-changes.spec.tsand another incomputation-suspension.spec.ts.Types of changes
Related issues:
Checklist: